Re: [PATCH net-next 19/33] tun: add XDP frame size

[Jason Wang <jasowang@xxxxxxxxxx>]

On 2020/4/23 上午12:08, Jesper Dangaard Brouer wrote:
> The tun driver have two code paths for running XDP (bpf_prog_run_xdp).
> In both cases 'buflen' contains enough tailroom for skb_shared_info.
>
> Cc: Jason Wang <jasowang@xxxxxxxxxx>
> Signed-off-by: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>


Acked-by: Jason Wang <jasowang@xxxxxxxxxx>


> ---
>   drivers/net/tun.c |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 44889eba1dbc..c54f967e2c66 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -1671,6 +1671,7 @@ static struct sk_buff *tun_build_skb(struct tun_struct *tun,
>   		xdp_set_data_meta_invalid(&xdp);
>   		xdp.data_end = xdp.data + len;
>   		xdp.rxq = &tfile->xdp_rxq;
> +		xdp.frame_sz = buflen;
>   
>   		act = bpf_prog_run_xdp(xdp_prog, &xdp);
>   		if (act == XDP_REDIRECT || act == XDP_TX) {
> @@ -2411,6 +2412,7 @@ static int tun_xdp_one(struct tun_struct *tun,
>   		}
>   		xdp_set_data_meta_invalid(xdp);
>   		xdp->rxq = &tfile->xdp_rxq;
> +		xdp->frame_sz = buflen;
>   
>   		act = bpf_prog_run_xdp(xdp_prog, xdp);
>   		err = tun_xdp_act(tun, xdp_prog, xdp, act);