On Sat, 25 Apr 2020 at 01:12, Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > Ah, I see what you are saying... I can just declare array as > > const char *attach_type_strings[__MAX_BPF_ATTACH_TYPE] = { ... } > That would address my concern, thanks! > to prevent this. There is still this issue of potentially getting back > NULL pointer. But that warrants separate "audit" of the code usage and > fixing appropriately, I don't think it belongs in this patch set. Agreed, we can keep that for later. My main concern for this review was the other point above anyway. Thank you, Quentin