On Mon, Apr 20, 2020 at 10:46 AM Stanislav Fomichev <sdf@xxxxxxxxxx> wrote: > > Currently the following prog types don't fall back to bpf_base_func_proto() > (instead they have cgroup_base_func_proto which has a limited set of > helpers from bpf_base_func_proto): > * BPF_PROG_TYPE_CGROUP_DEVICE > * BPF_PROG_TYPE_CGROUP_SYSCTL > * BPF_PROG_TYPE_CGROUP_SOCKOPT > > I don't see any specific reason why we shouldn't use bpf_base_func_proto(), > every other type of program (except bpf-lirc and, understandably, tracing) > use it, so let's fall back to bpf_base_func_proto for those prog types > as well. > > This basically boils down to adding access to the following helpers: > * BPF_FUNC_get_prandom_u32 > * BPF_FUNC_get_smp_processor_id > * BPF_FUNC_get_numa_node_id > * BPF_FUNC_tail_call > * BPF_FUNC_ktime_get_ns > * BPF_FUNC_spin_lock (CAP_SYS_ADMIN) > * BPF_FUNC_spin_unlock (CAP_SYS_ADMIN) > * BPF_FUNC_jiffies64 (CAP_SYS_ADMIN) > > I've also added bpf_perf_event_output() because it's really handy for > logging and debugging. > > Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxx> Thanks for the cleanup. Applied.
