On Sun, Apr 19, 2020 at 8:16 PM Song Liu <songliubraving@xxxxxx> wrote: > @@ -971,14 +982,14 @@ union bpf_attr { > * > * int ret; > * struct bpf_tunnel_key key = {}; > - * > + * > * ret = bpf_skb_get_tunnel_key(skb, &key, sizeof(key), 0); > * if (ret < 0) > * return TC_ACT_SHOT; // drop packet > - * > + * > * if (key.remote_ipv4 != 0x0a000001) > * return TC_ACT_SHOT; // drop packet > - * > + * > * return TC_ACT_OK; // accept packet > * > * This interface can also be used with all encapsulation devices Please avoid touching random lines or were they meaningful? In such case separate pls put them in the separate patch. The rest looks good to me. Please add corresponding libbpf support and selftest.