On Tue, Apr 21, 2020 at 12:23:30PM -0700, Andrey Ignatov wrote: > > if (ret == 1 && ctx.new_updated) { > > - *new_buf = ctx.new_val; > > + *buf = ctx.new_val; > > Original value of *buf should be freed before overriding it here > otherwise it's lost/leaked unless I missed something. > > Other than this BPF part of this patch looks good to me. Feel free to > add my Ack on the next iteration with this fix. Thanks, fixed. Can you also comment on "bpf-cgroup: remove unused exports" ?