Re: [RFC] uapi: Convert stat.h #define flags to enums

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [RFC] uapi: Convert stat.h #define flags to enums
From: "Daniel Xu" <dxu@xxxxxxxxx>
Date: Mon, 20 Apr 2020 09:37:42 -0700
Cc: <linux-kernel@xxxxxxxxxxxxxxx>, <bpf@xxxxxxxxxxxxxxx>, <kernel-team@xxxxxx>, <jolsa@xxxxxxxxxx>, <brendan.d.gregg@xxxxxxxxx>, <andrii.nakryiko@xxxxxxxxx>, <ast@xxxxxxxxxx>
In-reply-to: <20200420083046.GB28749@infradead.org>

Hi Christoph,

On Sun Apr 19, 2020 at 6:30 PM PST, Christoph Hellwig wrote:
> And that breaks every userspace program using ifdef to check if a
> symbolic name has been defined.

How about shadowing #define's? Like for `enum nfnetlink_groups` in
include/uapi/linux/netfilter/nfnetlink.h .

Thanks,
Daniel

Follow-Ups:
- Re: [RFC] uapi: Convert stat.h #define flags to enums
  - From: Andrii Nakryiko

References:
- Re: [RFC] uapi: Convert stat.h #define flags to enums
  - From: Christoph Hellwig

Prev by Date: Re: [RFC PATCH bpf-next 0/6] bpf, printk: add BTF-based type printing
Next by Date: Re: [RFC PATCH bpf-next 0/6] bpf, printk: add BTF-based type printing
Previous by thread: Re: [RFC] uapi: Convert stat.h #define flags to enums
Next by thread: Re: [RFC] uapi: Convert stat.h #define flags to enums
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SoC] [Linux Rockchip SoC] [Linux Actions SoC] [Linux for Synopsys ARC Processors] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]

Powered by Linux