Re: [PATCH] xsk: fix out of boundary write in __xsk_rcv_memcpy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 6 Apr 2020 at 22:13, Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote:
>
> On 4/3/20 10:29 AM, Björn Töpel wrote:
> > On Fri, 3 Apr 2020 at 00:22, Jonathan Lemon <jonathan.lemon@xxxxxxxxx> wrote:
> >> On 2 Apr 2020, at 0:52, Li RongQing wrote:
> >>
> >>> first_len is remainder of first page, if write size is
> >>> larger than it, out of page boundary write will happen
> >>>
> >>> Fixes: c05cd3645814 "(xsk: add support to allow unaligned chunk placement)"
> >>> Signed-off-by: Li RongQing <lirongqing@xxxxxxxxx>
> >>
> >> Acked-by: Jonathan Lemon <jonathan.lemon@xxxxxxxxx>
> >
> > Good catch!
> > Acked-by: Björn Töpel <bjorn.topel@xxxxxxxxx>
>
> Applied, thanks!
>
> Björn, Magnus, others, would be really valuable to have a proper kselftest suite
> in BPF for covering everything xsk related, including such corner cases as Li fixed
> here, wdyt? ;-)
>

Indeed. It's *very much* overdue. :-(


Björn

> Thanks,
> Daniel




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux