On 25-Mär 18:51, Andrii Nakryiko wrote: > On Wed, Mar 25, 2020 at 8:27 AM KP Singh <kpsingh@xxxxxxxxxxxx> wrote: > > > > From: KP Singh <kpsingh@xxxxxxxxxx> > > > > Introduce types and configs for bpf programs that can be attached to > > LSM hooks. The programs can be enabled by the config option > > CONFIG_BPF_LSM. > > > > Signed-off-by: KP Singh <kpsingh@xxxxxxxxxx> > > Reviewed-by: Brendan Jackman <jackmanb@xxxxxxxxxx> > > Reviewed-by: Florent Revest <revest@xxxxxxxxxx> > > Reviewed-by: Thomas Garnier <thgarnie@xxxxxxxxxx> > > Acked-by: Yonghong Song <yhs@xxxxxx> > > --- > > Looks good to me, so please add by ack, but I think it would be easier > to review if this was combined with patch #4, which adds verifier > support and kernel/bpf/syscall.c support. On its own this patch just > adds random unused stuff. The ordering becomes tricky as we are using the CONFIG_BPF_LSM in "bpf: lsm: provide attachment points for BPF LSM programs". If it's not too much trouble, I would appreciate if we can keep the order. > > Acked-by: Andrii Nakryiko <andriin@xxxxxx> Added your ack Thanks :) - KP > > > MAINTAINERS | 1 + > > include/linux/bpf.h | 3 +++ > > include/linux/bpf_types.h | 4 ++++ > > include/uapi/linux/bpf.h | 2 ++ > > init/Kconfig | 12 ++++++++++++ > > kernel/bpf/Makefile | 1 + > > kernel/bpf/bpf_lsm.c | 17 +++++++++++++++++ > > kernel/trace/bpf_trace.c | 12 ++++++------ > > tools/include/uapi/linux/bpf.h | 2 ++ > > tools/lib/bpf/libbpf_probes.c | 1 + > > 10 files changed, 49 insertions(+), 6 deletions(-) > > create mode 100644 kernel/bpf/bpf_lsm.c > > > > [...]