On Wed, Mar 25, 2020 at 3:58 PM kbuild test robot <lkp@xxxxxxxxx> wrote: > > Hi Andrii, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on bpf-next/master] > [cannot apply to bpf/master cgroup/for-next v5.6-rc7 next-20200325] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Andrii-Nakryiko/Add-support-for-cgroup-bpf_link/20200326-055942 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > config: i386-tinyconfig (attached as .config) > compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > > All warnings (new ones prefixed by >>): > > In file included from include/linux/cgroup-defs.h:22:0, > from include/linux/cgroup.h:28, > from include/linux/memcontrol.h:13, > from include/linux/swap.h:9, > from include/linux/suspend.h:5, > from arch/x86/kernel/asm-offsets.c:13: > >> include/linux/bpf-cgroup.h:380:45: warning: 'struct bpf_link' declared inside parameter list will not be visible outside of this definition or declaration > static inline int cgroup_bpf_replace(struct bpf_link *link, > ^~~~~~~~ > -- > In file included from include/linux/cgroup-defs.h:22:0, > from include/linux/cgroup.h:28, > from include/linux/memcontrol.h:13, > from include/linux/swap.h:9, > from include/linux/suspend.h:5, > from arch/x86/kernel/asm-offsets.c:13: > >> include/linux/bpf-cgroup.h:380:45: warning: 'struct bpf_link' declared inside parameter list will not be visible outside of this definition or declaration > static inline int cgroup_bpf_replace(struct bpf_link *link, > ^~~~~~~~ > 20 real 6 user 8 sys 71.33% cpu make prepare > > vim +380 include/linux/bpf-cgroup.h > > 379 It's a matter of forward declaring struct bpf_link here. Will fix in v3, but I'll wait a bit for any feedback before updating. > > 380 static inline int cgroup_bpf_replace(struct bpf_link *link, > 381 struct bpf_prog *old_prog, > 382 struct bpf_prog *new_prog) > 383 { > 384 return -EINVAL; > 385 } > 386 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
