On Thu, Mar 19, 2020 at 10:00 AM Jakub Sitnicki <jakub@xxxxxxxxxxxxxx> wrote: > > On Thu, Mar 19, 2020 at 01:46 PM CET, YueHaibing wrote: > > If BPF_STREAM_PARSER is not set, gcc warns: > > > > net/ipv4/tcp_bpf.c:483:12: warning: 'tcp_bpf_sendpage' defined but not used [-Wunused-function] > > net/ipv4/tcp_bpf.c:395:12: warning: 'tcp_bpf_sendmsg' defined but not used [-Wunused-function] > > net/ipv4/tcp_bpf.c:13:13: warning: 'tcp_bpf_stream_read' defined but not used [-Wunused-function] > > > > Moves the unused functions into the #ifdef > > > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > > --- > > In addition to this fix, looks like tcp_bpf_recvmsg can be static and > also conditional on CONFIG_BPF_STREAM_PARSER. > > Reviewed-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx> Fixes tag is missing as well?