On Tue, Mar 17, 2020 at 3:13 PM Stanislav Fomichev <sdf@xxxxxxxxxx> wrote: > > On Tue, Mar 17, 2020 at 3:08 PM Nick Desaulniers > <ndesaulniers@xxxxxxxxxx> wrote: > > > > On Tue, Mar 17, 2020 at 3:01 PM Fangrui Song <maskray@xxxxxxxxxx> wrote: > > > > > > On 2020-03-17, Stanislav Fomichev wrote: > > > >Please keep small changelog here, for example: > > > > > > > >v5: > > > >* rebased on top of bpfnext > > > > > > Thanks for the tip. Add them at the bottom? > > > > "Below the fold" see this patch I just sent out: > > https://lore.kernel.org/lkml/20200317215515.226917-1-ndesaulniers@xxxxxxxxxx/T/#u > > grep "Changes" > > > > $ git format-patch -v2 HEAD~ > > $ vim 0001-...patch > > <manually add changelog "below the fold"> > BPF subtree prefers the changelog in the commit body, not the comments > (iow, before ---). > Add them at the end of you message, see, for example: > https://lore.kernel.org/bpf/a428fb88-9b53-27dd-a195-497755944921@xxxxxxxxxxxxx/T/ Sigh, every maintainer is a special snowflake. In our tree, you're only allowed to commit on Thursdays under a blood moon. /s But thanks for the note. -- Thanks, ~Nick Desaulniers
