On 2020-03-11 at 16:55:38 +0100, Song Liu <songliubraving@xxxxxx> wrote: > > > > On Mar 11, 2020, at 5:34 AM, Tobias Klauser <tklauser@xxxxxxxxxx> wrote: > > > > When compiling bpftool on a system where the /usr/include/asm symlink > > doesn't exist (e.g. on an Ubuntu system without gcc-multilib installed), > > the build fails with: > > > > CLANG skeleton/profiler.bpf.o > > In file included from skeleton/profiler.bpf.c:4: > > In file included from /usr/include/linux/bpf.h:11: > > /usr/include/linux/types.h:5:10: fatal error: 'asm/types.h' file not found > > #include <asm/types.h> > > ^~~~~~~~~~~~~ > > 1 error generated. > > make: *** [Makefile:123: skeleton/profiler.bpf.o] Error 1 > > > > To fix this, add /usr/include/$(uname -m)-linux-gnu to the clang search > > path so <asm/types.h> can be found. > > > > Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxx> > > Looks good, with a nit below. > > Acked-by: Song Liu <songliubraving@xxxxxx> > > > --- > > tools/bpf/bpftool/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile > > index 20a90d8450f8..3cc0644fd91e 100644 > > --- a/tools/bpf/bpftool/Makefile > > +++ b/tools/bpf/bpftool/Makefile > > @@ -120,7 +120,7 @@ $(OUTPUT)_bpftool: $(_OBJS) $(LIBBPF) > > $(QUIET_LINK)$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $(_OBJS) $(LIBS) > > > > skeleton/profiler.bpf.o: skeleton/profiler.bpf.c > > - $(QUIET_CLANG)$(CLANG) -I$(srctree)/tools/lib -g -O2 -target bpf -c $< -o $@ > > + $(QUIET_CLANG)$(CLANG) -I/usr/include/$(shell uname -m)-linux-gnu -I$(srctree)/tools/lib -g -O2 -target bpf -c $< -o $@ > > Nit: this line is too long. It is better to break it into two lines. Thanks. Will send a v2, also with Toke's feedback regarding commit message included.
