Re: [PATCH bpf] bpf: fix cgroup ref leak in cgroup_bpf_inherit on out-of-memory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 09, 2020 at 03:40:17PM -0700, Andrii Nakryiko wrote:
> There is no compensating cgroup_bpf_put() for each ancestor cgroup in
> cgroup_bpf_inherit(). If compute_effective_progs returns error, those cgroups
> won't be freed ever. Fix it by putting them in cleanup code path.
> 
> Fixes: e10360f815ca ("bpf: cgroup: prevent out-of-order release of cgroup bpf")
> Signed-off-by: Andrii Nakryiko <andriin@xxxxxx>

Acked-by: Roman Gushchin <guro@xxxxxx>

Thanks, Andrii!



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux