On Fri, Mar 6, 2020 at 5:06 PM John Fastabend <john.fastabend@xxxxxxxxx> wrote: > > Alexei Starovoitov wrote: > > On Tue, Mar 03, 2020 at 12:46:58PM +0100, Jesper Dangaard Brouer wrote: ... > > > Tested on ixgbe with xdp_rxq_info --skb-mode and --action XDP_DROP: > > > - Before: 4,816,430 pps > > > - After : 7,749,678 pps > > > (Note that ixgbe in native mode XDP_DROP 14,704,539 pps) > > > > > But why do we care about generic-XDP performance? Seems users should > just use XDP proper on ixgbe and i40e its supported. I think the point was to show the performance benefit of skipping the normalization (admittedly for a specific workload, tinygrams; my other patch to control xdpgeneric_linearize covered a different range of packet sizes). On a side note I think it would be more useful to report times in ns/pkt, as they can be applied to other drivers too. Specifically here I would have written: Before: average 207 ns/pkt (1s / 4.816 Mpps) After: average 129 ns/pkt (1s / 7.750 Mpps) cheers luigi
