Re: [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums
From: Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>
Date: Wed, 4 Mar 2020 07:50:20 -0800
Cc: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>, Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx>, Andrii Nakryiko <andriin@xxxxxx>, bpf <bpf@xxxxxxxxxxxxxxx>, Networking <netdev@xxxxxxxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxx>, Kernel Team <kernel-team@xxxxxx>, Yonghong Song <yhs@xxxxxx>
In-reply-to: <945cf1c4-78bb-8d3c-10e3-273d100ce41c@iogearbox.net>

On Wed, Mar 4, 2020 at 7:39 AM Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote:
>
> I was about to push the series out, but agree that there may be a risk for #ifndefs
> in the BPF C code. If we want to be on safe side, #define FOO FOO would be needed.

There is really no risk.
Let's not be paranoid about it and uglify bpf.h for no reason.

Follow-Ups:
- Re: [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums
  - From: Daniel Borkmann

References:
- [PATCH v3 bpf-next 0/3] Convert BPF UAPI constants into enum values
  - From: Andrii Nakryiko
- [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums
  - From: Andrii Nakryiko
- Re: [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums
  - From: Daniel Borkmann
- Re: [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums
  - From: Andrii Nakryiko
- Re: [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums
  - From: Toke Høiland-Jørgensen
- Re: [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums
  - From: Daniel Borkmann

Prev by Date: [PATCH bpf-next v3 0/7] Introduce BPF_MODIFY_RET tracing progs
Next by Date: Re: [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums
Previous by thread: Re: [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums
Next by thread: Re: [PATCH v3 bpf-next 1/3] bpf: switch BPF UAPI #define constants used from BPF program side to enums
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SoC] [Linux Rockchip SoC] [Linux Actions SoC] [Linux for Synopsys ARC Processors] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]