On 2/18/20 4:19 PM, Daniel Borkmann wrote: > On 2/18/20 11:23 PM, Toke Høiland-Jørgensen wrote: >> Jakub Kicinski <kuba@xxxxxxxxxx> writes: >>> On Tue, 18 Feb 2020 01:14:29 +0100 Lorenzo Bianconi wrote: >>>> Introduce "rx" prefix in the name scheme for xdp counters >>>> on rx path. >>>> Differentiate between XDP_TX and ndo_xdp_xmit counters >>>> >>>> Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> >>> >>> Sorry for coming in late. >>> >>> I thought the ability to attach a BPF program to a fexit of another BPF >>> program will put an end to these unnecessary statistics. IOW I maintain >>> my position that there should be no ethtool stats for XDP. >>> >>> As discussed before real life BPF progs will maintain their own stats >>> at the granularity of their choosing, so we're just wasting datapath >>> cycles. > > +1 There is value in having something as essential as stats available through standard APIs and tooling. mlx5, i40e, sfc, etc, etc already provide stats via ethtool. This patch is making mvneta consistent with existing stats from these other drivers.
