Hi Ilias, I love your patch! Yet something to improve: [auto build test ERROR on v5.6-rc1] [also build test ERROR on next-20200217] [cannot apply to net-next/master net/master linus/master ipvs/master v5.6-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Ilias-Apalodimas/net-page_pool-API-cleanup-and-comments/20200218-163634 base: bb6d3fb354c5ee8d6bde2d576eb7220ea09862b9 config: i386-randconfig-b002-20200218 (attached as .config) compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): ld: net/core/xdp.o: in function `__xdp_release_frame': >> net/core/xdp.c:426: undefined reference to `page_pool_release_page' vim +426 net/core/xdp.c 05296620f6d14d Jakub Kicinski 2018-07-11 415 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 416 /* Only called for MEM_TYPE_PAGE_POOL see xdp.h */ 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 417 void __xdp_release_frame(void *data, struct xdp_mem_info *mem) 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 418 { 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 419 struct xdp_mem_allocator *xa; 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 420 struct page *page; 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 421 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 422 rcu_read_lock(); 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 423 xa = rhashtable_lookup(mem_id_ht, &mem->id, mem_id_rht_params); 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 424 page = virt_to_head_page(data); 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 425 if (xa) 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 @426 page_pool_release_page(xa->page_pool, page); 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 427 rcu_read_unlock(); 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 428 } 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 429 EXPORT_SYMBOL_GPL(__xdp_release_frame); 6bf071bf09d4b2 Jesper Dangaard Brouer 2019-06-18 430 :::::: The code at line 426 was first introduced by commit :::::: 6bf071bf09d4b2ff3ee8783531e2ce814f0870cb xdp: page_pool related fix to cpumap :::::: TO: Jesper Dangaard Brouer <brouer@xxxxxxxxxx> :::::: CC: David S. Miller <davem@xxxxxxxxxxxxx> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
