Re: linux-5.6-rc1/tools/testing/selftests/bpf/prog_tests/select_reuseport.cc :826: possible cut-n-paste error ?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 10, 2020 at 01:42:45PM +0000, David Binderman wrote:
> Hello there,
> 
>     saved_tcp_fo = read_int_sysctl(TCP_FO_SYSCTL);
>     saved_tcp_syncookie = read_int_sysctl(TCP_SYNCOOKIE_SYSCTL);
>     if (saved_tcp_syncookie < 0 || saved_tcp_syncookie < 0)
>         goto out;
> 
> Maybe better code
> 
>     saved_tcp_fo = read_int_sysctl(TCP_FO_SYSCTL);
>     saved_tcp_syncookie = read_int_sysctl(TCP_SYNCOOKIE_SYSCTL);
>     if (saved_tcp_fo < 0 || saved_tcp_syncookie < 0)
Thanks for the report.  I will post a fix.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux