Em Fri, Jan 31, 2020 at 09:38:58AM +0100, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Jan 20, 2020 at 05:15:54PM +0300, Cengiz Can escreveu:
> > Please tell me if the `__maps__free_maps_by_name` frees the
> > `rw_semaphore`. If that's the case, should we change the order to unlock and free?
>
> No it doesn't free the rw_semaphore, that is in 'struct maps', what is
> being freed is just something protected by rw_semaphore,
> maps->maps_by_name, so your patch is right and I'm applying it, thanks.
BTW, you forgot to add:
Fixes: a7c2b572e217 ("perf map_groups: Auto sort maps by name, if needed")
Which I did, and next time please CC the perf tools reviewers, as noted
in MAINTAINERS, the lines starting with R:.
- Arnaldo
[acme@quaco perf]$ grep -A21 "PERFORMANCE EVENTS SUBSYSTEM$" MAINTAINERS
PERFORMANCE EVENTS SUBSYSTEM
M: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
M: Ingo Molnar <mingo@xxxxxxxxxx>
M: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
R: Mark Rutland <mark.rutland@xxxxxxx>
R: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
R: Jiri Olsa <jolsa@xxxxxxxxxx>
R: Namhyung Kim <namhyung@xxxxxxxxxx>
L: linux-kernel@xxxxxxxxxxxxxxx
T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core
S: Supported
F: kernel/events/*
F: include/linux/perf_event.h
F: include/uapi/linux/perf_event.h
F: arch/*/kernel/perf_event*.c
F: arch/*/kernel/*/perf_event*.c
F: arch/*/kernel/*/*/perf_event*.c
F: arch/*/include/asm/perf_event.h
F: arch/*/kernel/perf_callchain.c
F: arch/*/events/*
F: arch/*/events/*/*
F: tools/perf/
[acme@quaco perf]$
