Re: [PATCH bpf] bpf: Reuse log from btf_prase_vmlinux() in btf_struct_ops_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 27, 2020 at 10:34 AM Andrii Nakryiko
<andrii.nakryiko@xxxxxxxxx> wrote:
>
> On Mon, Jan 27, 2020 at 9:52 AM Martin KaFai Lau <kafai@xxxxxx> wrote:
> >
> > Instead of using a locally defined "struct bpf_verifier_log log = {}",
> > btf_struct_ops_init() should reuse the "log" from its calling
> > function "btf_parse_vmlinux()".  It should also resolve the
> > frame-size too large compiler warning in some ARCH.
> >
> > Fixes: 27ae7997a661 ("bpf: Introduce BPF_PROG_TYPE_STRUCT_OPS")
> > Signed-off-by: Martin KaFai Lau <kafai@xxxxxx>
> > ---
>
> LGTM, but there is typo in subject (btf_prase_vmlinux).
>
> Acked-by: Andrii Nakryiko <andriin@xxxxxx>

Tested. All works.

Dave,
if you haven't sent PR yet may be you can apply this patch
directly to silence the warning?
Not a big deal if not. I don't see this warn with default config.

Acked-by: Alexei Starovoitov <ast@xxxxxxxxxx>



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux