From: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx> Date: Fri, 7 Mar 2025 13:10:29 +0100 > On Wed, Mar 05, 2025 at 05:21:26PM +0100, Alexander Lobakin wrote: >> Currently, queues are associated 1:1 with interrupt vectors as it's >> assumed queues are always interrupt-driven. >> In order to use a queue without an interrupt, idpf still needs to have >> a vector assigned to it to flush descriptors. This vector can be global >> and only one for the whole vport to handle all its noirq queues. >> Always request one excessive vector and configure it in non-interrupt >> mode right away when creating vport, so that it can be used later by >> queues when needed. > > Description sort of miss the purpose of this commit, you don't ever > mention that your design choice for XDP Tx queues is to have them > irq-less. Because this is not directly related to XDP and maybe some time later more code could make use of noirq queues, who knows :> But I'll mention why this is needed, ok. > >> >> Co-developed-by: Michal Kubiak <michal.kubiak@xxxxxxxxx> >> Signed-off-by: Michal Kubiak <michal.kubiak@xxxxxxxxx> >> Signed-off-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx> >> --- >> drivers/net/ethernet/intel/idpf/idpf.h | 8 +++ >> drivers/net/ethernet/intel/idpf/idpf_txrx.h | 4 ++ >> drivers/net/ethernet/intel/idpf/idpf_dev.c | 11 +++- >> drivers/net/ethernet/intel/idpf/idpf_lib.c | 2 +- >> drivers/net/ethernet/intel/idpf/idpf_txrx.c | 8 +++ >> drivers/net/ethernet/intel/idpf/idpf_vf_dev.c | 11 +++- >> .../net/ethernet/intel/idpf/idpf_virtchnl.c | 53 +++++++++++++------ >> 7 files changed, 79 insertions(+), 18 deletions(-) Thanks, Olek
