missing error code in do_loader() bpf_object__open_file() failed, but return 0 This means the command's exit status code was successful, so make sure to return the correct error code. To maintain consistency with other locations where bpf_object__open_file() is called, it returns -1 instead. Link: https://lore.kernel.org/bpf/d3b5b4b4-19bb-4619-b4dd-86c958c4a367@stanley.mountain/t/#u Closes: https://github.com/libbpf/bpftool/issues/156 Signed-off-by: Sewon Nam <swnam0729@xxxxxxxxx> --- tools/bpf/bpftool/prog.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c index e71be67f1d86..52ffb74ae4e8 100644 --- a/tools/bpf/bpftool/prog.c +++ b/tools/bpf/bpftool/prog.c @@ -1928,6 +1928,7 @@ static int do_loader(int argc, char **argv) obj = bpf_object__open_file(file, &open_opts); if (!obj) { + err = -1; p_err("failed to open object file"); goto err_close_obj; } -- 2.39.3 (Apple Git-146)
