Re: [PATCH bpf-next v1 1/3] bpf: simple DFA-based live registers analysis

[Eduard Zingerman <eddyz87@xxxxxxxxx>]

On Fri, 2025-02-28 at 18:01 -0800, Alexei Starovoitov wrote:
> On Thu, Feb 27, 2025 at 10:01 PM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote:

[...]

> > @@ -3379,10 +3388,7 @@ static int check_subprogs(struct bpf_verifier_env *env)
> >                         goto next;
> >                 if (BPF_OP(code) == BPF_EXIT || BPF_OP(code) == BPF_CALL)
> >                         goto next;
> > -               if (code == (BPF_JMP32 | BPF_JA))
> > -                       off = i + insn[i].imm + 1;
> > -               else
> > -                       off = i + insn[i].off + 1;
> > +               off = i + jmp_offset(&insn[i]) + 1;
> 
> Nice cleanup, but pls split it into pre-patch,
> so that main liveness logic is in the main patch.

Thanks for the feedback.
I'll include all requested changes in v2.

[...]