On Fri, Feb 28, 2025 at 11:13 AM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote: > > A few small veristat improvements: > - It is possible to hit command line parameters number limit, > e.g. when running veristat for all object files generated for > test_progs. This patch-set adds an option to read objects files list > from a file. > - Correct usage of strerror() function. > - Avoid printing log lines to CSV output. > All makes sense, and superficially LGTM, but I'd like Mykyta to take a look when he gets a chance, as he's been working with veristat quite a lot recently. One thing I wanted to propose/ask. Do you think it would be useful to allow <object>:<program> pattern to be specified to allow picking just one program out of the object file? I normally do `veristat <object> -f<program>` for this, but being able to do `veristat <obj1>:<prog1> <obj2>:<prog2> ...` seems useful, no? (-f<program> would apply to all objects, btw, which isn't a big problem in practice, but still). Oh, and we could allow globbing in `veristat <obj>:<blah*>`. Thoughts? > Eduard Zingerman (3): > veristat: @files-list.txt notation for object files list > veristat: strerror expects positive number (errno) > veristat: report program type guess results to sdterr > > tools/testing/selftests/bpf/veristat.c | 70 +++++++++++++++++++++----- > 1 file changed, 57 insertions(+), 13 deletions(-) > > -- > 2.48.1 >
