> -----Original Message----- > From: Stanislav Fomichev <stfomichev@xxxxxxxxx> > Sent: Thursday, February 20, 2025 11:17 PM > To: Vyavahare, Tushar <tushar.vyavahare@xxxxxxxxx> > Cc: bpf@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; bjorn@xxxxxxxxxx; Karlsson, > Magnus <magnus.karlsson@xxxxxxxxx>; Fijalkowski, Maciej > <maciej.fijalkowski@xxxxxxxxx>; jonathan.lemon@xxxxxxxxx; > davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; ast@xxxxxxxxxx; > daniel@xxxxxxxxxxxxx > Subject: Re: [PATCH bpf-next 2/6] selftests/xsk: Add tail adjustment functionality > to XDP > > On 02/20, Tushar Vyavahare wrote: > > Introduce a new function, xsk_xdp_adjust_tail, within the XDP program > > to adjust the tail of packets. This function utilizes > > bpf_xdp_adjust_tail to modify the packet size dynamically based on the 'count' > variable. > > > > If the adjustment fails, the packet is dropped using XDP_DROP to > > ensure processing of only correctly modified packets. > > > > Signed-off-by: Tushar Vyavahare <tushar.vyavahare@xxxxxxxxx> > > Any reason not to combine patches 2..5 into a single one? I looked through each > one briefly and it's a bit hard to follow when trying to put everything together.. Maybe that was too many patches. How about this? #1: selftests/xsk: Add packet stream replacement function #2: selftests/xsk: Add tail adjustment test functionality to AF_XDP. #3: selftests/xsk: Add support check for bpf_xdp_adjust_tail() helper in xskxceiver #4: selftests/xsk: Implement and test packet resizing with bpf_xdp_adjust_tail