Re: [PATCH bpf-next v1 01/10] bpf: copy_verifier_state() should copy 'loop_entry' field

[Eduard Zingerman <eddyz87@xxxxxxxxx>]

On Mon, 2025-02-24 at 10:56 -0800, Andrii Nakryiko wrote:

[...]

> > @@ -19243,6 +19244,8 @@ static int do_check(struct bpf_verifier_env *env)
> >                                                 return err;
> >                                         break;
> >                                 } else {
> > +                                       if (WARN_ON_ONCE(env->cur_state->loop_entry))
> > +                                               env->cur_state->loop_entry = NULL;
> 
> this would be a huge violation of invariant, so why wouldn't this be a
> BUG()? At the very least, we should return -EFAULT ASAP, instead of
> trying to "recover" from unknown broken state.

I'll send a follow-up.

[...]