On Mon, Feb 24, 2025 at 4:16 AM Pu Lehui <pulehui@xxxxxxxxxx> wrote: > > > > On 2025/2/21 8:30, Andrii Nakryiko wrote: > > On Tue, Feb 18, 2025 at 10:29 PM Pu Lehui <pulehui@xxxxxxxxxxxxxxx> wrote: > >> > >> From: Pu Lehui <pulehui@xxxxxxxxxx> > >> > >> pahole commit [0] of supporting distilled base btf feature released on > >> pahole v1.28 rather than v1.26. So let's correct this. > >> > >> Link: https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=c7b1f6a29ba1 [0] > >> Signed-off-by: Pu Lehui <pulehui@xxxxxxxxxx> > >> --- > >> scripts/Makefile.btf | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/scripts/Makefile.btf b/scripts/Makefile.btf > >> index c3cbeb13de50..fbaaec2187e5 100644 > >> --- a/scripts/Makefile.btf > >> +++ b/scripts/Makefile.btf > >> @@ -24,7 +24,7 @@ else > >> pahole-flags-$(call test-ge, $(pahole-ver), 126) = -j$(JOBS) --btf_features=encode_force,var,float,enum64,decl_tag,type_tag,optimized_func,consistent_func,decl_tag_kfuncs > >> > >> ifneq ($(KBUILD_EXTMOD),) > >> -module-pahole-flags-$(call test-ge, $(pahole-ver), 126) += --btf_features=distilled_base > >> +module-pahole-flags-$(call test-ge, $(pahole-ver), 128) += --btf_features=distilled_base > >> endif > > > > Alan, > > > > Is this correct? Can you please check and ack? Thanks! > > Maybe Alan doesn't have time to reply at the moment. We can use the > following command to check that in pahole.git: > > $ git name-rev c7b1f6a29ba1 > c7b1f6a29ba1 tags/v1.28~73 yep, I was a bit lazy to search for specific commit ;) I like this command, though: $ git tag --contains c7b1f6a29ba1 v1.28 v1.29 regardless, applied to bpf-next, thanks > > > > >> > >> endif > >> -- > >> 2.34.1 > >>
