On Wed, 19 Feb 2025 21:53:41 -0500, Faizal Rahim <faizal.abdul.rahim@xxxxxxxxxxxxxxx> wrote: > @@ -1258,23 +1236,8 @@ static int stmmac_set_mm(struct net_device *ndev, struct ethtool_mm_cfg *cfg, > if (err) > return err; > > - /* Wait for the verification that's currently in progress to finish */ > - timer_shutdown_sync(&fpe_cfg->verify_timer); > - > - spin_lock_irqsave(&fpe_cfg->lock, flags); > - > - fpe_cfg->verify_enabled = cfg->verify_enabled; > - fpe_cfg->pmac_enabled = cfg->pmac_enabled; > - fpe_cfg->verify_time = cfg->verify_time; > - fpe_cfg->tx_enabled = cfg->tx_enabled; > - > - if (!cfg->verify_enabled) > - fpe_cfg->status = ETHTOOL_MM_VERIFY_STATUS_DISABLED; > - > + ethtool_mmsv_set_mm(&priv->fpe_cfg.mmsv, cfg); > stmmac_fpe_set_add_frag_size(priv, frag_size); > - stmmac_fpe_apply(priv); Well, I would prefer keeping stmmac_fpe_set_add_frag_size() before ethtool_mmsv_set_mm(), but not after, the VERIFY process should be triggered after all the parameters are set. > - > - spin_unlock_irqrestore(&fpe_cfg->lock, flags); > > return 0; > }
