On Wed, Jan 22, 2020 at 02:05:43PM +0100, Jakub Sitnicki wrote: > Now that sockmap can hold listening sockets, when setting up the psock we > will (i) grab references to verdict/parser progs, and (2) override socket > upcalls sk_data_ready and sk_write_space. > > We cannot redirect to listening sockets so we don't need to link the socket > to the BPF progs, but more importantly we don't want the listening socket > to have overridden upcalls because they would get inherited by child > sockets cloned from it. > > Introduce a separate initialization path for listening sockets that does > not change the upcalls and ignores the BPF progs. The change makes sense to me. Acked-by: Martin KaFai Lau <kafai@xxxxxx>
