On 13/02/2025 06:14, Jakub Kicinski wrote: > On Mon, 10 Feb 2025 16:52:15 +0200 Roger Quadros wrote: >> - /* Compute additional headroom to be reserved */ >> - headroom = (xdp.data - xdp.data_hard_start) - skb_headroom(skb); >> - skb_reserve(skb, headroom); >> + headroom = xdp.data - xdp.data_hard_start; >> + } > > I'm gonna do a minor touch up here and set the headroom in "else" hope > you don't mind. Easier to read the code if the init isnt all the way up > at definition. Also that way reverse xmas tree is maintained. Thank you for the touch up. -- cheers, -roger
