Re: [PATCH bpf-next 3/3] selftests/bpf: Add selftest for attaching fexit to __noreturn functions

[Yafang Shao <laoar.shao@xxxxxxxxx>]

On Wed, Feb 12, 2025 at 1:23 AM Song Liu <song@xxxxxxxxxx> wrote:
>
> On Mon, Feb 10, 2025 at 6:34 PM Yafang Shao <laoar.shao@xxxxxxxxx> wrote:
> >
> > The reuslt:
> >
> >   $ tools/testing/selftests/bpf/test_progs --name=fexit_noreturns
> >   #99      fexit_noreturns:OK
> >   Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED
> >
> > Signed-off-by: Yafang Shao <laoar.shao@xxxxxxxxx>
> > ---
> >  .../selftests/bpf/prog_tests/fexit_noreturns.c      | 13 +++++++++++++
> >  tools/testing/selftests/bpf/progs/fexit_noreturns.c | 13 +++++++++++++
> >  2 files changed, 26 insertions(+)
> >  create mode 100644 tools/testing/selftests/bpf/prog_tests/fexit_noreturns.c
> >  create mode 100644 tools/testing/selftests/bpf/progs/fexit_noreturns.c
> >
> > diff --git a/tools/testing/selftests/bpf/prog_tests/fexit_noreturns.c b/tools/testing/selftests/bpf/prog_tests/fexit_noreturns.c
> > new file mode 100644
> > index 000000000000..588362275ed7
> > --- /dev/null
> > +++ b/tools/testing/selftests/bpf/prog_tests/fexit_noreturns.c
> > @@ -0,0 +1,13 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +
> > +#include <test_progs.h>
> > +#include "fexit_noreturns.skel.h"
> > +
> > +void test_fexit_noreturns(void)
> > +{
> > +       struct fexit_noreturns *fexit_skel;
> > +
> > +       fexit_skel = fexit_noreturns__open_and_load();
> > +       ASSERT_NULL(fexit_skel, "fexit_load");
> > +       ASSERT_EQ(errno, EINVAL, "can't load fexit_noreturns");
> > +}
> > diff --git a/tools/testing/selftests/bpf/progs/fexit_noreturns.c b/tools/testing/selftests/bpf/progs/fexit_noreturns.c
> > new file mode 100644
> > index 000000000000..003aafe2b896
> > --- /dev/null
> > +++ b/tools/testing/selftests/bpf/progs/fexit_noreturns.c
> > @@ -0,0 +1,13 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +
> > +#include <linux/bpf.h>
> > +#include <bpf/bpf_helpers.h>
> > +#include <bpf/bpf_tracing.h>
> > +
> > +char _license[] SEC("license") = "GPL";
> > +
> > +SEC("fexit/do_exit")
>
> We can add:
>
> __failure __msg(<verifier log added in 2/3>)
>
> here.
> > +int BPF_PROG(noreturns)
> > +{
> > +       return 0;
> > +}
> > --
> > 2.43.5
> >
>
> Then, test_fexit_noreturns above can simply be:
>
> void test_fexit_noreturns(void)
> {
>         RUN_TESTS(fexit_noreturns);
> }
>

Thanks for your suggestion; it really helps simplify the code.

-- 
Regards
Yafang