> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of > Vladimir Oltean > Sent: Wednesday, February 12, 2025 11:01 PM > To: Faizal Rahim <faizal.abdul.rahim@xxxxxxxxxxxxxxx> > Cc: Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw > <przemyslaw.kitszel@xxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; > David S . Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet > <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni > <pabeni@xxxxxxxxxx>; Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>; > Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>; Simon Horman > <horms@xxxxxxxxxx>; Russell King <linux@xxxxxxxxxxxxxxx>; Alexei > Starovoitov <ast@xxxxxxxxxx>; Daniel Borkmann <daniel@xxxxxxxxxxxxx>; > Jesper Dangaard Brouer <hawk@xxxxxxxxxx>; John Fastabend > <john.fastabend@xxxxxxxxx>; Furong Xu <0x1207@xxxxxxxxx>; Russell King > <rmk+kernel@xxxxxxxxxxxxxxx>; Serge Semin <fancer.lancer@xxxxxxxxx>; > Xiaolei Wang <xiaolei.wang@xxxxxxxxxxxxx>; Suraj Jaiswal > <quic_jsuraj@xxxxxxxxxxx>; Kory Maincent <kory.maincent@xxxxxxxxxxx>; > Gal Pressman <gal@xxxxxxxxxx>; Jesper Nilsson <jesper.nilsson@xxxxxxxx>; > Andrew Halaney <ahalaney@xxxxxxxxxx>; Choong Yong Liang > <yong.liang.choong@xxxxxxxxxxxxxxx>; Kunihiko Hayashi > <hayashi.kunihiko@xxxxxxxxxxxxx>; Gomes, Vinicius > <vinicius.gomes@xxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-stm32@st-md- > mailman.stormreply.com; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > bpf@xxxxxxxxxxxxxxx > Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 0/9] igc: Add support for > Frame Preemption feature in IGC Please start commit title from slam letters: Igc: add ... > On Mon, Feb 10, 2025 at 02:01:58AM -0500, Faizal Rahim wrote: > > Introduces support for the FPE feature in the IGC driver. > > > > The patches aligns with the upstream FPE API: > > > https://patchwork.kernel.org/project/netdevbpf/cover/20230220122343.1 > 1 > > 56614-1-vladimir.oltean@xxxxxxx/ > > > https://patchwork.kernel.org/project/netdevbpf/cover/20230119122705.7 > 3 > > 054-1-vladimir.oltean@xxxxxxx/ > > > > It builds upon earlier work: > > > https://patchwork.kernel.org/project/netdevbpf/cover/20220520011538.1 > 0 > > 98888-1-vinicius.gomes@xxxxxxxxx/ > > > > The patch series adds the following functionalities to the IGC driver: > > a) Configure FPE using `ethtool --set-mm`. > > b) Display FPE settings via `ethtool --show-mm`. > > c) View FPE statistics using `ethtool --include-statistics --show-mm'. > > e) Enable preemptible/express queue with `fp`: > > tc qdisc add ... root taprio \ > > fp E E P P > > Any reason why you are only enabling the preemptible traffic classes with > taprio, and not with mqprio as well? I see there will have to be some work > harmonizing igc's existing understanding of ring priorities with what Kurt did in > 9f3297511dae ("igc: Add MQPRIO offload support"), and I was kind of > expecting to see a proposal for that as part of this.
