Andrii Nakryiko writes:
On Tue, Jan 21, 2020 at 12:29 PM Chris Down <chris@xxxxxxxxxxxxxx> wrote:
Andrii Nakryiko writes:
>> --- a/scripts/link-vmlinux.sh
>> +++ b/scripts/link-vmlinux.sh
>> @@ -108,13 +108,15 @@ gen_btf()
>> local bin_arch
>>
>> if ! [ -x "$(command -v ${PAHOLE})" ]; then
>> - info "BTF" "${1}: pahole (${PAHOLE}) is not available"
>> + printf 'BTF: %s: pahole (%s) is not available\n' \
>> + "${1}" "${PAHOLE}" >&2
>
>any reason not to use echo instead of printf? would be more minimal change
I generally avoid using echo because it has a bunch of portability gotchas
which printf mostly doesn't have. If you'd prefer echo, that's fine though,
just let me know and I can send v2.
The rest of the script is using echo for errors, so let's stick to it
for consistency. Thanks!
Sure thing, I'll send v2. Thanks! :-)