Re: [PATCH net-next 3/3] selftests/bpf: add rto max for bpf_setsockopt test

Jason Xing <kerneljasonxing@xxxxxxxxx> · Thu, 13 Feb 2025 11:13:44 +0800

On Thu, Feb 13, 2025 at 10:30 AM Kuniyuki Iwashima <kuniyu@xxxxxxxxxx> wrote:
>
> From: Jason Xing <kerneljasonxing@xxxxxxxxx>
> Date: Thu, 13 Feb 2025 08:43:54 +0800
> > Add TCP_BPF_RTO_MAX selftests for active and passive flows
> > in the BPF_SOCK_OPS_ACTIVE_ESTABLISHED_CB and
> > BPF_SOCK_OPS_PASSIVE_ESTABLISHED_CB bpf callbacks.
> >
> > Signed-off-by: Jason Xing <kerneljasonxing@xxxxxxxxx>
> > ---
> >  .../bpf/prog_tests/tcp_hdr_options.c          | 28 +++++++++++++------
> >  .../bpf/progs/test_tcp_hdr_options.c          | 26 +++++++++++++++++
> >  .../selftests/bpf/test_tcp_hdr_options.h      |  3 ++
>
> It would be nice to update sol_tcp_testsp[] with TCP_RTO_MAX_MS
> in tools/testing/selftests/bpf/progs/setget_sockopt.c.

Sure, it's not hard to add this test.

Thanks,
Jason