On 2/10/25 2:13 PM, Alan Maguire wrote: > On 07/02/2025 02:14, Ihor Solodrai wrote: >> Add a feature flag "attributes" (default: false) controlling whether >> pahole is allowed to generate BTF attributes: type tags and decl tags >> with kind_flag = 1. >> >> This is necessary for backward compatibility, as BPF verifier does not >> recognize tags with kind_flag = 1 prior to (at least) 6.14-rc1 [1]. >> >> [1] https://lore.kernel.org/bpf/20250130201239.1429648-1-ihor.solodrai@xxxxxxxxx/ >> >> Signed-off-by: Ihor Solodrai <ihor.solodrai@xxxxxxxxx> > Needs update to pahole man page describing the new "attributes" > btf_feature, but aside from that LGTM. I was wondering what have I missed. Thanks. > > Reviewed-by: Alan Maguire <alan.maguire@xxxxxxxxxx> > > [...]
