Re: [PATCH bpf-next] selftests/bpf: implement setting global variables in veristat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 5, 2025 at 5:29 PM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote:
>
> On Wed, 2025-02-05 at 17:06 -0800, Andrii Nakryiko wrote:
>
> [...]
>
> > but main point from me here would be to avoid parsing multiple values,
> > it's better to allow repeated -G uses and treat each value as strictly
> > single variable initialization. So instead of:
> >
> > ./veristat wq.bpf.o  --set-global-vars "a = 0; b = 1; c = 2; d = 3;"
> >
> > we'll have:
> >
> > ./veristat wq.bpf.o  -G "a = 0" -G "b = 1" -G "c = 2" -G "d = 3"
> >
> > A touch more verbose for many variables, but not significantly so. On
> > the other hand, less parsing, and less arbitrary choices of what
> > separator (;) to use. WDYT?
> >
> > pw-bot: cr
>
> In a sibling thread I asked about '-g @file' support, allowing to list
> variables in files. This could be worked around as $(cat file) in
> the command line, of course.

What I proposed doesn't interfere with this, it actually helps with
it: each line is treated as a separate `-G <line>` invocation, and
each line initializes a single variable.

>
> [...]
>





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux