Re: [PATCH bpf-next v3 08/18] bpf: net_sched: Support implementation of Qdisc_ops in bpf

[Amery Hung <ameryhung@xxxxxxxxx>]

On Tue, Feb 4, 2025 at 2:18 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Fri, 31 Jan 2025 11:28:47 -0800 Amery Hung wrote:
> > +             if (new &&
> > +                 !(parent->flags & TCQ_F_MQROOT) &&
> > +                 new->ops->owner == BPF_MODULE_OWNER) {
> > +                     NL_SET_ERR_MSG(extack, "BPF qdisc not supported on a non root");
> > +                     return -EINVAL;
> > +             }
>
> This check should live in bpf_qdisc.c

Might be a dumb question, but could you explain why this is preferred?

I can certainly do the check in Qdisc_ops::init instead though.

Thanks,
Amery