> -----Original Message----- > From: Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> > Sent: Tuesday, 4 February 2025 18:02 > To: Amit Cohen <amcohen@xxxxxxxxxx> > Cc: Petr Machata <petrm@xxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski > <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; Network Development > <netdev@xxxxxxxxxxxxxxx>; Ido Schimmel <idosch@xxxxxxxxxx>; Alexei Starovoitov <ast@xxxxxxxxxx>; Daniel Borkmann > <daniel@xxxxxxxxxxxxx>; Jesper Dangaard Brouer <hawk@xxxxxxxxxx>; John Fastabend <john.fastabend@xxxxxxxxx>; bpf > <bpf@xxxxxxxxxxxxxxx>; mlxsw <mlxsw@xxxxxxxxxx> > Subject: Re: [PATCH net-next 00/12] mlxsw: Preparations for XDP support > > On Tue, Feb 4, 2025 at 3:59 PM Amit Cohen <amcohen@xxxxxxxxxx> wrote: > > > > > > > > > -----Original Message----- > > > From: Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> > > > Sent: Tuesday, 4 February 2025 17:56 > > > To: Petr Machata <petrm@xxxxxxxxxx> > > > Cc: David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni > > > <pabeni@xxxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; Network Development <netdev@xxxxxxxxxxxxxxx>; Amit Cohen > > > <amcohen@xxxxxxxxxx>; Ido Schimmel <idosch@xxxxxxxxxx>; Alexei Starovoitov <ast@xxxxxxxxxx>; Daniel Borkmann > > > <daniel@xxxxxxxxxxxxx>; Jesper Dangaard Brouer <hawk@xxxxxxxxxx>; John Fastabend <john.fastabend@xxxxxxxxx>; bpf > > > <bpf@xxxxxxxxxxxxxxx>; mlxsw <mlxsw@xxxxxxxxxx> > > > Subject: Re: [PATCH net-next 00/12] mlxsw: Preparations for XDP support > > > > > > On Tue, Feb 4, 2025 at 11:06 AM Petr Machata <petrm@xxxxxxxxxx> wrote: > > > > > > > > Amit Cohen writes: > > > > > > > > A future patch set will add support for XDP in mlxsw driver. This set adds > > > > some preparations. > > > > > > Why? > > > What is the goal here? > > > My understanding is that mlxsw is a hw switch and skb-s are used to > > > implement tap functionality for few listeners. > > > The volume of such packets is supposed to be small. > > > Even if XDP is added there is a huge mismatch in packet rates. > > > Hence the question. Why bother? > > > > You're right, most of packets should be handled by HW, XDP is mainly useful for telemetry. > > Why skb path is not enough? We get better packet rates using XDP, this can be useful to redirect packets to a server for analysis for example.
