Re: [PATCH bpf-next v3 01/14] selftests/bpf: helpers: Add append_tid()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Martin,

On 1/28/25 11:49 PM, Martin KaFai Lau wrote:
On 1/28/25 1:57 AM, Bastien Curutchet (eBPF Foundation) wrote:
Some tests can't be run in parallel because they use same namespace
names or veth names.

Create an helper that appends the thread ID to a given string. 8
characters are used for it (7 digits + '\0')

Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@xxxxxxxxxxx>
---
  tools/testing/selftests/bpf/network_helpers.c | 11 +++++++++++
  tools/testing/selftests/bpf/network_helpers.h | 10 ++++++++++
  2 files changed, 21 insertions(+)

diff --git a/tools/testing/selftests/bpf/network_helpers.c b/tools/ testing/selftests/bpf/network_helpers.c index 80844a5fb1feef2ff73c2f0293e52495803ab769..d2ff7521aaa696ed04d8f1308394b4c01c1c038b 100644
--- a/tools/testing/selftests/bpf/network_helpers.c
+++ b/tools/testing/selftests/bpf/network_helpers.c
@@ -446,6 +446,17 @@ char *ping_command(int family)
      return "ping";
  }
+int append_tid(char *str, size_t offset)
nit. offset should always be strlen(str) now. The append_tid will be easier to use if the append_tid always does the strlen() itself to figure out the end of the str.

It will be useful to replace the "size_t offset" arg with "size_t sz" which tells the max size of the "char *str" and the append_tid does a check to ensure there is enough space to append the "%07d" tid.


Ok, I'll do that.

Best regards,
Bastien




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux