Re: [PATCH net] vmxnet3: Fix tx queue race condition with XDP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 24 Jan 2025 14:32:11 +0530 Sankararaman Jayaraman wrote:
> + * Copyright (C) 2008-2025, VMware, Inc. All Rights Reserved.

Please don't update copyright dates in a fix.
It increases the size of the patch and risk of a conflict.

> @@ -123,7 +123,9 @@ vmxnet3_xdp_xmit_frame(struct vmxnet3_adapter *adapter,
>  	struct page *page;
>  	u32 buf_size;
>  	u32 dw2;
> +	unsigned long irq_flags;

please order variable declaration lines longest to shortest

> +	spin_lock_irqsave(&tq->tx_lock, irq_flags);

why _irqsave() ?
-- 
pw-bot: cr




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux