Re: [PATCH net-next v3 3/8] bpf: cpumap: switch to GRO from netif_receive_skb_list()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH net-next v3 3/8] bpf: cpumap: switch to GRO from netif_receive_skb_list()
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Thu, 16 Jan 2025 17:16:53 -0800
Cc: Andrew Lunn <andrew+netdev@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Lorenzo Bianconi <lorenzo@xxxxxxxxxx>, Daniel Xu <dxu@xxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, Toke Høiland-Jørgensen <toke@xxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, Martin KaFai Lau <martin.lau@xxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20250115151901.2063909-4-aleksander.lobakin@intel.com>

On Wed, 15 Jan 2025 16:18:56 +0100 Alexander Lobakin wrote:
> +		empty = __ptr_ring_empty(rcpu->queue);
> +		if (packets += n >= NAPI_POLL_WEIGHT || empty) {

please remove the assignment from the condition

References:
- [PATCH net-next v3 0/8] bpf: cpumap: enable GRO for XDP_PASS frames
  - From: Alexander Lobakin
- [PATCH net-next v3 3/8] bpf: cpumap: switch to GRO from netif_receive_skb_list()
  - From: Alexander Lobakin

Prev by Date: Re: [PATCH net-next v3 2/8] net: gro: expose GRO init/cleanup to use outside of NAPI
Next by Date: Re: Crash when attaching uretprobes to processes running in Docker
Previous by thread: Re: [PATCH net-next v3 3/8] bpf: cpumap: switch to GRO from netif_receive_skb_list()
Next by thread: Re: [PATCH net-next v3 3/8] bpf: cpumap: switch to GRO from netif_receive_skb_list()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SoC] [Linux Rockchip SoC] [Linux Actions SoC] [Linux for Synopsys ARC Processors] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]