>> @@ -1337,8 +1358,12 @@ void otx2_aura_pool_free(struct otx2_nic *pfvf) >> pool = &pfvf->qset.pool[pool_id]; >> qmem_free(pfvf->dev, pool->stack); >> qmem_free(pfvf->dev, pool->fc_addr); >> - page_pool_destroy(pool->page_pool); >> - pool->page_pool = NULL; >> + if (pool->page_pool) { >> + page_pool_destroy(pool->page_pool); >> + pool->page_pool = NULL; >> + } > >It looks like the above delta is not needed: page_pool_destroy() handles >correctly NULL value for the page pool. [Suman] ack, will update in v4 > >/P