On Wed, Jan 15, 2020 at 3:12 PM Martin Lau <kafai@xxxxxx> wrote: > > On Wed, Jan 15, 2020 at 02:59:59PM -0800, Andrii Nakryiko wrote: > > On Wed, Jan 15, 2020 at 2:50 PM Martin Lau <kafai@xxxxxx> wrote: > > > > > > On Wed, Jan 15, 2020 at 02:46:10PM -0800, Andrii Nakryiko wrote: > > > > On Wed, Jan 15, 2020 at 2:28 PM Martin KaFai Lau <kafai@xxxxxx> wrote: > > > > > > > > > > This patch makes bpftool support dumping a map's value properly > > > > > when the map's value type is a type of the running kernel's btf. > > > > > (i.e. map_info.btf_vmlinux_value_type_id is set instead of > > > > > map_info.btf_value_type_id). The first usecase is for the > > > > > BPF_MAP_TYPE_STRUCT_OPS. > > > > > > > > > > Signed-off-by: Martin KaFai Lau <kafai@xxxxxx> > > > > > --- > > > > > > > > LGTM. > > > > > > > > Acked-by: Andrii Nakryiko <andriin@xxxxxx> > > > Thanks for the review! > > > > > > I just noticied I forgot to remove the #include "libbpf_internal.h". > > > I will respin one more. > > > > didn't notice that. Please also update a subject on patch exposing > > libbpf_find_kernel_btf (it still mentions old name). > oops. already went out. :p > The commit message mentioned the renaming from old to new name. no worries
