1 static const char *const syscalltbl[] = {
2 [0] = "restart_syscall",
3 [1] = "exit",
4 [2] = "fork",
5 [3] = "read",
6 [4] = "write",
7 [5] = "open",
8 [6] = "close",
9 [7] = "waitpid",
10 [8] = "creat",
11 [9] = "link",
12 [10] = "unlink",
13 [11] = "execve",
14 [12] = "chdir",
15 [13] = "timeâ??,
16 [13] = "timeâ??,
17 [14] = "mknod",
18 [15] = "chmod",
19 [16] = "lchown",
20 [17] = "break",
21 [18] = "oldstat",
22 [18] = "oldstatâ??,
Line number 15 an 16 shows two entries for time. Similarly last two lines for oldstat. This is picked form https://github.com/torvalds/linux/blob/master/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl
13 32 time sys_time32
13 64 time sys_time
18 32 oldstat sys_stat sys_ni_syscall
18 64 oldstat sys_ni_syscall
For same nr, two entries are there. In the arch specific version of the script that makes the syscall table, this was handled : https://github.com/torvalds/linux/blob/master/tools/perf/arch/powerpc/entry/syscalls/mksyscalltbl#L28
So we will need change in generic script also. Proposing below change :
diff --git a/tools/perf/scripts/syscalltbl.sh b/tools/perf/scripts/syscalltbl.sh
index 1ce0d5aa8b50..d66cec10cc2d 100755
--- a/tools/perf/scripts/syscalltbl.sh
+++ b/tools/perf/scripts/syscalltbl.sh
@@ -75,8 +75,10 @@ max_nr=0
# the params are: nr abi name entry compat
# use _ for intentionally unused variables according to SC2034
while read nr _ name _ _; do
- emit "$nr" "$name" >> $outfile
- max_nr=$nr
+ if [ "$max_nr" -lt "$nr" ]; then
+ emit "$nr" "$name" >> $outfile
+ max_nr=$nr
+ fi
done < $sorted_table
rm -f $sorted_table
Arnaldo,
I see we have this patch series in perf-tools-next. If we need above change as a separate patch, please let me know.
Thanks
Athira
>
>
