Jeroen de Borst wrote: > Reviewed-By: Jeroen de Borst <jeroendb@xxxxxxxxxx> > > > > On Mon, Jan 6, 2025 at 10:02 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > > > Commit f85949f98206 ("xdp: add xdp_set_features_flag utility routine") > > added routines to inform the core about XDP flag changes. > > GVE support was added around the same time and missed using them. > > > > GVE only changes the flags on error recover or resume. > > Presumably the flags may change during resume if VM migrated. > > User would not get the notification and upper devices would > > not get a chance to recalculate their flags. > > > > Fixes: 75eaae158b1b ("gve: Add XDP DROP and TX support for GQI-QPL format") > > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> Reviewed-by: Willem de Bruijn <willemb@xxxxxxxxxx> Thanks! > > --- > > CC: jeroendb@xxxxxxxxxx Reminder: please don't top post