On 2024/12/20 20:29, Ilias Apalodimas wrote: > Hi Yunsheng, > > On Fri, 13 Dec 2024 at 14:35, Yunsheng Lin <linyunsheng@xxxxxxxxxx> wrote: >> >> introduce page_pool_to_pp() API to avoid caller accessing >> page->pp directly. >> > > I think we already have way too many abstractions, I'd say we need > less not more. I don't know what others think, but I don't see what we > gain from this I am not sure how it is related to 'abstraction' here. Either we don't allow drivers accessing the page->pp directly, otherwise it seems better to provide a proper API for that as my understanding as it seems better not to mess with internal detail of page_pool. > > Thanks > /Ilias
