Hi Linus,
On 12/21/24 8:23 PM, Linus Torvalds wrote:
On Fri, 20 Dec 2024 at 16:21, Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote:
- Fix inlining of bpf_get_smp_processor_id helper for !CONFIG_SMP
systems (Andrea Righi)
LOL.
However, it strikes me that this only handles the x86-64 case.
The other cases (arm64, RISC-V) may not have the pcpu_hot crash, but
they still generate silly code to load off the thread pointer. Does
that even exist (or get initialized) in UP?
End result: I think you should have done the UP case separately and
outside the CONFIG_X86_64.. And why do this only for the
"verifier_inlines_helper_call()" case rather than just do it
unconditionally?
All makes sense, I'll look into following up on your above suggestion
once back from travel!
Anyway, I obviously pulled this, but it does seem silly.
Thanks & Merry Xmas,
Daniel
