On Tue, Dec 17, 2024 at 02:22:54AM +0200, Vladimir Oltean wrote:
> I spent a bit of time extracting stmmac's core logic and putting it in
> ethtool.
There's at least one bug in this conversion:
-- >8 --
diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c
index 3063fe00eef7..d305208dd0c8 100644
--- a/net/ethtool/mm.c
+++ b/net/ethtool/mm.c
@@ -292,7 +292,7 @@ static void ethtool_mmsv_configure_tx(struct ethtool_mmsv *mmsv,
static void ethtool_mmsv_configure_pmac(struct ethtool_mmsv *mmsv,
bool pmac_enabled)
{
- mmsv->ops->configure_tx(mmsv, pmac_enabled);
+ mmsv->ops->configure_pmac(mmsv, pmac_enabled);
}
static void ethtool_mmsv_send_mpacket(struct ethtool_mmsv *mmsv,
-- >8 --
