On Thu, 2024-12-12 at 19:50 +0000, Alan Maguire wrote:
> On 11/12/2024 02:12, Eduard Zingerman wrote:
> > When using BTF as a source, pfunct should now be able to print
> > btf_decl_tags for programs like below:
> >
> > #define __tag(x) __attribute__((btf_decl_tag(#x)))
> > __tag(a) __tag(b) void foo(void) {}
> >
> > This situation arises after recent kernel changes, where tags 'kfunc'
> > and 'bpf_fastcall' are added to some functions. To avoid dependency on
> > a recent kernel version test this by compiling a small C program using
> > clang with --target=bpf, which would instruct clang to generate .BTF
> > section.
> >
> > Signed-off-by: Eduard Zingerman <eddyz87@xxxxxxxxx>
>
> nit: the test is great but it would be good to print out a description
> even in non-verbose mode; when I run it via ./tests I see
>
> 5: Ok
>
> could we just echo the comment below, i.e.
>
> 5 : Check that pfunct can print btf_decl_tags read from BTF: Ok
>
> ?
>
> Reviewed-by: Alan Maguire <alan.maguire@xxxxxxxxxx>
> Tested-by: Alan Maguire <alan.maguire@xxxxxxxxxx>
Makes sense, will change.
Will wait a bit and resend v2 in the evening.
Thank you.
[...]
