Jakub Sitnicki wrote:
> Now that SOCKMAP can store listening sockets, user-space and BPF API is
> open to a new set of potential pitfalls. Exercise the map operations (with
> extra attention to code paths susceptible to races between map ops and
> socket cloning), and BPF helpers that work with SOCKMAP to gain confidence
> that all works as expected.
>
> Signed-off-by: Jakub Sitnicki <jakub@xxxxxxxxxxxxxx>
> ---
[...]
> +static void test_sockmap_insert_listening(int family, int sotype, int mapfd)
> +{
> + u64 value;
> + u32 key;
> + int s;
> +
> + s = listen_loopback(family, sotype);
> + if (s < 0)
> + return;
Will the test be marked OK if listen fails here? Should we mark it skipped or
maybe even failed? Just concerned it may be passing even if the update doesn't
actually happen.
> +
> + key = 0;
> + value = s;
> + xbpf_map_update_elem(mapfd, &key, &value, BPF_NOEXIST);
> + xclose(s);
> +}
Thanks,
John
